Don't make other players flash on screen flash#72
Merged
Desdaemon merged 1 commit intoynoproject:masterfrom Aug 10, 2025
Merged
Don't make other players flash on screen flash#72Desdaemon merged 1 commit intoynoproject:masterfrom
Desdaemon merged 1 commit intoynoproject:masterfrom
Conversation
It makes no visual difference now that player names are affected by screen flashes. Fixes PlayerOther flickering in MAP2059 (Sunset Savannah, Yume 2kki) seen during the event triggered by using the Fairy effect. Regression introduced in 9c20341.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #70, depends on #71. Once #71 gets merged player names will be implicitly affected by screen flashes just like player sprites, making explicit flashing redundant.